From 20ab7f1564badd2aef73270b32d96d982137e0f1 Mon Sep 17 00:00:00 2001
From: Michael Bauer <michael-bauer@posteo.de>
Date: Thu, 13 Jun 2024 20:35:42 +0200
Subject: [PATCH] Handle required fields in absence-creation-form

---
 .../absences/AbsenceCreationDialog.vue        |   3 +
 .../absences/AbsenceCreationForm.vue          | 123 ++++++++++--------
 2 files changed, 75 insertions(+), 51 deletions(-)

diff --git a/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationDialog.vue b/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationDialog.vue
index d1b848c4f..88672264a 100644
--- a/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationDialog.vue
+++ b/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationDialog.vue
@@ -31,6 +31,7 @@
       :end-date="endDate"
       :comment="comment"
       :absence-reason="absenceReason"
+      @valid="formValid = $event"
       @persons="persons = $event"
       @start-date="startDate = $event"
       @end-date="endDate = $event"
@@ -56,6 +57,7 @@
         i18n-key="actions.continue"
         @click="form = false"
         :loading="loading"
+        :disabled="!formValid"
       />
       <save-button
         v-else
@@ -92,6 +94,7 @@ export default {
     return {
       popup: false,
       form: true,
+      formValid: false,
       persons: [],
       startDate: "",
       endDate: "",
diff --git a/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationForm.vue b/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationForm.vue
index 23c6db202..f8b20a0ba 100644
--- a/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationForm.vue
+++ b/aleksis/apps/alsijil/frontend/components/coursebook/absences/AbsenceCreationForm.vue
@@ -1,56 +1,70 @@
 <template>
-  <v-container>
-    <v-row>
-      <v-autocomplete
-        :label="$t('forms.labels.persons')"
-        :items="allPersons"
-        item-text="fullName"
-        return-object
-        multiple
-        :value="persons"
-        @input="$emit('persons', $event)"
-      />
-    </v-row>
-    <v-row>
-      <v-col
-        cols="12"
-        :sm="6"
-        class="pl-0"
-        >
-        <date-field
-          :label="$t('forms.labels.start')"
-          :max="endDate"
-          :value="startDate"
-          @input="$emit('start-date', $event)"
+  <v-form @input="$emit('valid', $event)">
+    <v-container>
+      <v-row>
+        <div aria-required="true" class="full-width">
+          <v-autocomplete
+            :label="$t('forms.labels.persons')"
+            :items="allPersons"
+            item-text="fullName"
+            return-object
+            multiple
+            :rules="rules"
+            :value="persons"
+            @input="$emit('persons', $event)"
           />
-      </v-col>
-      <v-col
-        cols="12"
-        :sm="6"
-        class="pr-0"
-        >
-        <date-field
-          :label="$t('forms.labels.end')"
-          :min="startDate"
-          :value="endDate"
-          @input="$emit('end-date', $event)"
+        </div>
+      </v-row>
+      <v-row>
+        <v-col
+          cols="12"
+          :sm="6"
+          class="pl-0"
+          >
+          <div aria-required="true">
+            <date-field
+              :label="$t('forms.labels.start')"
+              :max="endDate"
+              :rules="rules"
+              :value="startDate"
+              @input="$emit('start-date', $event)"
+            />
+          </div>
+        </v-col>
+        <v-col
+          cols="12"
+          :sm="6"
+          class="pr-0"
+          >
+          <div aria-required="true">
+            <date-field
+              :label="$t('forms.labels.end')"
+              :min="startDate"
+              :rules="rules"
+              :value="endDate"
+              @input="$emit('end-date', $event)"
+            />
+          </div>
+        </v-col>
+      </v-row>
+      <v-row>
+        <v-text-field
+          :label="$t('forms.labels.comment')"
+          :value="comment"
+          @input="$emit('comment', $event)"
+        />
+      </v-row>
+      <v-row>
+        <div aria-required="true">
+          <absence-reason-group-select
+            :rules="rules"
+            :value="absenceReason"
+            @input="$emit('absence-reason', $event)"
           />
-      </v-col>
-    </v-row>
-    <v-row>
-      <v-text-field
-        :label="$t('forms.labels.comment')"
-        :value="comment"
-        @input="$emit('comment', $event)"
-      />
-    </v-row>
-    <v-row>
-      <absence-reason-group-select
-        :value="absenceReason"
-        @input="$emit('absence-reason', $event)"
-      />
-    </v-row>
-  </v-container>
+        </div>
+      </v-row>
+    </v-container>
+  </v-form>
 </template>
 
 <script>
@@ -64,7 +78,7 @@ export default {
     AbsenceReasonGroupSelect,
     DateField,
   },
-  emits: ["persons", "start-date", "end-date", "comment", "absence-reason"],
+  emits: ["valid", "persons", "start-date", "end-date", "comment", "absence-reason"],
   apollo: {
     // TODO: Query currently returns all persons. But should return
     // only persons the current user can create ParticipationStati and
@@ -93,5 +107,12 @@ export default {
       required: true,
     },
   },
+  data() {
+    return {
+      rules: [
+          (value) => value.length > 0,
+      ],
+    };
+  },
 };
 </script>
-- 
GitLab