From 27d8f0dda72ea6e02e946dbf28347ac3e156e9a8 Mon Sep 17 00:00:00 2001
From: magicfelix <felix@felix-zauberer.de>
Date: Thu, 18 Apr 2024 17:12:36 +0200
Subject: [PATCH] Remove not working constraint
---
.../0020_documentation_extramark_colour_bg_and_more.py | 4 ----
aleksis/apps/alsijil/models.py | 8 ++------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/aleksis/apps/alsijil/migrations/0020_documentation_extramark_colour_bg_and_more.py b/aleksis/apps/alsijil/migrations/0020_documentation_extramark_colour_bg_and_more.py
index 6122c1344..602a266ad 100644
--- a/aleksis/apps/alsijil/migrations/0020_documentation_extramark_colour_bg_and_more.py
+++ b/aleksis/apps/alsijil/migrations/0020_documentation_extramark_colour_bg_and_more.py
@@ -89,8 +89,4 @@ class Migration(migrations.Migration):
model_name='newpersonalnote',
constraint=models.CheckConstraint(check=models.Q(models.Q(('note', ''), _negated=True), ('extra_mark__isnull', False), _connector='OR'), name='unique_absence_per_documentation'),
),
- migrations.AddConstraint(
- model_name='documentation',
- constraint=models.CheckConstraint(check=models.Q(('amends__isnull', True), ('course__isnull', True), _negated=True), name='either_course_or_amends'),
- ),
]
diff --git a/aleksis/apps/alsijil/models.py b/aleksis/apps/alsijil/models.py
index 930bbc3d5..ccf3f1617 100644
--- a/aleksis/apps/alsijil/models.py
+++ b/aleksis/apps/alsijil/models.py
@@ -511,12 +511,8 @@ class Documentation(CalendarEvent):
class Meta:
verbose_name = _("Documentation")
verbose_name_plural = _("Documentations")
- constraints = [
- models.CheckConstraint(
- check=~Q(course__isnull=True, amends__isnull=True),
- name="either_course_or_amends",
- ),
- ]
+ # should check if object has either course or amends,
+ # which is not possible via constraint, because amends is not local to Documentation
@classmethod
def get_for_coursebook(
--
GitLab