From 286e031cbe894d0830cc89e1e1fb3ee178c26ecc Mon Sep 17 00:00:00 2001
From: Hangzhi Yu <hangzhi@protonmail.com>
Date: Mon, 8 Apr 2024 18:03:44 +0200
Subject: [PATCH] Remove some unneccesary checks for teacher status in courses
---
aleksis/apps/alsijil/util/predicates.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/aleksis/apps/alsijil/util/predicates.py b/aleksis/apps/alsijil/util/predicates.py
index c2ce7d98a..de57ee133 100644
--- a/aleksis/apps/alsijil/util/predicates.py
+++ b/aleksis/apps/alsijil/util/predicates.py
@@ -310,11 +310,10 @@ def is_course_teacher(user: User, obj: Course):
def is_lesson_event_teacher(user: User, obj: LessonEvent):
"""Predicate for teachers of a lesson event.
- Checks whether the person linked to the user is a teacher in the lesson event,
- or a teacher of the course, if the lesson event has one.
+ Checks whether the person linked to the user is a teacher in the lesson event.
"""
if obj:
- return obj.course and is_course_teacher(user, obj.course) or user.person in obj.all_teachers
+ return user.person in obj.all_teachers
return False
@@ -419,8 +418,6 @@ def can_edit_documentation(user: User, obj: Documentation):
return is_lesson_event_teacher(user, obj.lesson_event) | is_lesson_event_group_owner(
user, obj.lesson_event
)
- if obj.course:
- return is_course_teacher(user, obj.course)
return False
--
GitLab