From 29b5aa3aac7abdeff516dba646fd5740ecb700c4 Mon Sep 17 00:00:00 2001
From: Jonathan Weth <git@jonathanweth.de>
Date: Tue, 27 Oct 2020 17:05:53 +0100
Subject: [PATCH] Use filter in favour of for loops
---
aleksis/apps/alsijil/model_extensions.py | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/aleksis/apps/alsijil/model_extensions.py b/aleksis/apps/alsijil/model_extensions.py
index fddde6d59..7881eb9f9 100644
--- a/aleksis/apps/alsijil/model_extensions.py
+++ b/aleksis/apps/alsijil/model_extensions.py
@@ -177,10 +177,14 @@ def get_lesson_documentation(
if not week:
week = self.week
# Use all to make effect of prefetched data
- for documentation in self.documentations.all():
- if documentation.week == week.week and documentation.year == week.year:
- return documentation
- return None
+ doc_filter = filter(
+ lambda d: d.week == week.week and d.year == week.year,
+ self.dopycumentations.all(),
+ )
+ try:
+ return next(doc_filter)
+ except StopIteration:
+ return None
@LessonPeriod.method
--
GitLab