From 402fb55c81f1e740c375c5f39f48e5774a7ce1ab Mon Sep 17 00:00:00 2001 From: Jonathan Weth <git@jonathanweth.de> Date: Fri, 11 Jun 2021 13:30:30 +0200 Subject: [PATCH] Show 'Lesson documentations' tab on person overview only if the person is a teacher --- CHANGELOG.rst | 4 ++++ aleksis/apps/alsijil/views.py | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 287a130b0..cae8fa826 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -9,6 +9,10 @@ and this project adheres to `Semantic Versioning`_. Unreleased ---------- +Changed +~~~~~~~ +* Show 'Lesson documentations' tab on person overview only if the person is a teacher. + Fixed ~~~~~ diff --git a/aleksis/apps/alsijil/views.py b/aleksis/apps/alsijil/views.py index e2d68f961..3999324f2 100644 --- a/aleksis/apps/alsijil/views.py +++ b/aleksis/apps/alsijil/views.py @@ -957,8 +957,8 @@ def overview_person(request: HttpRequest, id_: Optional[int] = None) -> HttpResp filter_dict["person"] = person context["filter_form"] = filter_form - register_objects = generate_list_of_all_register_objects(filter_dict) - if register_objects: + if request.user.person.is_teacher: + register_objects = generate_list_of_all_register_objects(filter_dict) table = RegisterObjectTable(register_objects) items_per_page = request.user.person.preferences[ "alsijil__register_objects_table_items_per_page" -- GitLab