From 56d1d23f4529a7511a57518dccc4c05e30fdfae6 Mon Sep 17 00:00:00 2001
From: Julian Leucker <leuckerj@gmail.com>
Date: Wed, 6 Jul 2022 01:07:08 +0200
Subject: [PATCH] Create constant for ID_NO_PERSON
---
.../static/js/vue/components/alsijil/PersonalNotes.js | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/aleksis/apps/alsijil/static/js/vue/components/alsijil/PersonalNotes.js b/aleksis/apps/alsijil/static/js/vue/components/alsijil/PersonalNotes.js
index 6e54bbf8e..72dbad179 100644
--- a/aleksis/apps/alsijil/static/js/vue/components/alsijil/PersonalNotes.js
+++ b/aleksis/apps/alsijil/static/js/vue/components/alsijil/PersonalNotes.js
@@ -1,4 +1,9 @@
+const ID_NO_PERSON = null;
+
export default {
+ created() {
+ this.ID_NO_PERSON = ID_NO_PERSON;
+ },
methods: {
removePersonalNote(item) {
console.log("removing personal note", item);
@@ -18,6 +23,9 @@ export default {
this.editedExtraMarks = personalNote.extra_marks || [];
},
personalNoteByStudentID(studentID) {
+ if (this.editedPersonID === ID_NO_PERSON) {
+ return {};
+ }
return this.personalNotes.filter(item => item.student.id === studentID)[0] || {};
}
},
@@ -28,7 +36,7 @@ export default {
dialog: false,
// Absent versp. exc. type hw note
editPersonalNoteId: null,
- editedPersonID: -1,
+ editedPersonID: ID_NO_PERSON,
editedTardiness: 0,
editedAbsent: false,
editedExcused: false,
--
GitLab