diff --git a/aleksis/apps/alsijil/models.py b/aleksis/apps/alsijil/models.py index ad6aa5c4f7a5a93b40fe1e37e53837be344571e1..c4487066cb6536c66d244dc1fd06350970c91dc1 100644 --- a/aleksis/apps/alsijil/models.py +++ b/aleksis/apps/alsijil/models.py @@ -680,6 +680,16 @@ class Documentation(CalendarEvent): obj.save() return obj + @classmethod + def get_or_create_by_id(cls, _id: str|int, user): + if _id.startswith("DUMMY"): + return cls.create_from_lesson_event( + user, + *cls.parse_dummy(_id), + ) + + return cls.objects.get(id=_id) + class ParticipationStatus(CalendarEvent): """A participation or absence record about a single person. diff --git a/aleksis/apps/alsijil/schema/documentation.py b/aleksis/apps/alsijil/schema/documentation.py index 24029c245376a0d6a7fa8d35a6d4d5d8adebb17b..dd79c16952de8edbef3f6b0ab5bc8c14a07e9876 100644 --- a/aleksis/apps/alsijil/schema/documentation.py +++ b/aleksis/apps/alsijil/schema/documentation.py @@ -109,13 +109,7 @@ class DocumentationBatchCreateOrUpdateMutation(graphene.Mutation): # Sadly, we can't use the update_or_create method since create_defaults # is only introduced in Django 5.0 - if _id.startswith("DUMMY"): - obj = Documentation.create_from_lesson_event( - info.context.user, - *Documentation.parse_dummy(_id), - ) - else: - obj = Documentation.objects.get(id=_id) + obj = Documentation.get_or_create_by_id(_id, info.context.user) if not info.context.user.has_perm("alsijil.edit_documentation_rule", obj): raise PermissionDenied()