From bf15109768973565962963777eeefad9c5c6b9cb Mon Sep 17 00:00:00 2001 From: Jonathan Weth <git@jonathanweth.de> Date: Sat, 27 Mar 2021 13:26:42 +0100 Subject: [PATCH] Simplify getting of teacher names in _generate_dicts_for_lesson_periods --- aleksis/apps/alsijil/util/alsijil_helpers.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/aleksis/apps/alsijil/util/alsijil_helpers.py b/aleksis/apps/alsijil/util/alsijil_helpers.py index b5879b1f2..20d1a94ab 100644 --- a/aleksis/apps/alsijil/util/alsijil_helpers.py +++ b/aleksis/apps/alsijil/util/alsijil_helpers.py @@ -210,11 +210,7 @@ def _generate_dicts_for_lesson_periods( ): continue - teachers = ( - sub.teacher_names - if sub and sub.teachers.all() - else lesson_period.lesson.teacher_names - ) + teachers = lesson_period.teacher_names if ( filter_dict.get("subject") and filter_dict.get("subject") != lesson_period.get_subject() -- GitLab