From cc8a540e086748bce0a53dd681082959d0315582 Mon Sep 17 00:00:00 2001
From: Dominik George <dominik.george@teckids.org>
Date: Wed, 4 Sep 2019 13:52:19 +0200
Subject: [PATCH] Update comments on view logic.
---
biscuit/apps/alsijil/views.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/biscuit/apps/alsijil/views.py b/biscuit/apps/alsijil/views.py
index 4f6fa11f1..3a14e8015 100644
--- a/biscuit/apps/alsijil/views.py
+++ b/biscuit/apps/alsijil/views.py
@@ -43,7 +43,7 @@ def lesson(request: HttpRequest, week: Optional[int] = None, period_id: Optional
lesson_documentation_form = LessonDocumentationForm(
request.POST or None, instance=lesson_documentation, prefix='leson_documentation')
- # Create all missing personal notes about members of all groups in lesson
+ # FInd all persons in the associated groups that do not yet have a personal note for this lesson
missing_persons = Person.objects.annotate(
no_personal_notes=~Exists(PersonalNote.objects.filter(
week=wanted_week,
@@ -55,6 +55,8 @@ def lesson(request: HttpRequest, week: Optional[int] = None, period_id: Optional
is_active=True,
no_personal_notes=True
)
+
+ # Create all missing personal notes
PersonalNote.objects.bulk_create([
PersonalNote(person=person, lesson_period=lesson_period,
week=wanted_week) for person in missing_persons
--
GitLab