Resolve "Add rules and permissions"

Closes #73 (closed)

Closes #79 (closed)

aleksis/apps/alsijil/util/predicates.py

@@ -171,9 +171,14 @@ def is_personal_note_lesson_teacher(user: User, obj: PersonalNote) -> bool:
     """
     if hasattr(obj, "lesson_period"):
         if hasattr(obj.lesson_period, "lesson"):
-            return user.person in obj.lesson_period.lesson.teachers.all() or user.person in Person.objects.filter(
+            sub = obj.lesson_period.get_substitution()
+            if sub and user.person in Person.objects.filter(
                 lesson_substitutions=obj.lesson_period.get_substitution()
-            )
+            ):
+                return True
+
+            return user.person in obj.lesson_period.lesson.teachers.all()
+
         return False
     return False
 
@@ -211,6 +216,6 @@ def has_any_object_absence(user: User) -> bool:
 
 
 @predicate
-def is_teacher(user: User, obj: Model) -> bool:
+def is_teacher(user: User, obj: Person) -> bool:
     """Predicate which checks if the provided object is a teacher."""
-    return user.person.is_teacher()
+    return user.person.is_teacher