Resolve "Add task for checking plausibility of data"

Closes #91 (closed)

aleksis/apps/alsijil/data_checks.py

@@ -32,6 +32,18 @@ class SetGroupsWithCurrentGroupsSolveOption(SolveOption):
         check_result.delete()
 
 
+class ResetPersonalNoteSolveOption(SolveOption):
+    name = "reset_personal_note"
+    verbose_name = _("Reset personal note to defaults")
+
+    @classmethod
+    def solve(cls, check_result: "DataCheckResult"):
+        note = check_result.related_object
+        note.reset_values()
+        note.save()
+        check_result.delete()
+
+
 @DATA_CHECK_REGISTRY.register
 class NoPersonalNotesInCancelledLessonsDataCheck(DataCheck):
     name = "no_personal_notes_in_cancelled_lessons"
@@ -58,7 +70,6 @@ class NoPersonalNotesInCancelledLessonsDataCheck(DataCheck):
 
         for note in personal_notes:
             logging.info(f"Check personal note {note}")
-            sub = note.lesson_period.get_substitution(CalendarWeek(week=note.week, year=note.year))
             result = DataCheckResult.objects.get_or_create(
                 check=cls.name, content_type=ct, object_id=note.id
             )
@@ -168,3 +179,30 @@ class PersonalNoteOnHolidaysDataCheck(DataCheck):
                 result = DataCheckResult.objects.get_or_create(
                     check=cls.name, content_type=ct, object_id=note.id
                 )
+
+
+@DATA_CHECK_REGISTRY.register
+class ExcusesWithoutAbsences(DataCheck):
+    name = "excuses_without_absences"
+    verbose_name = _("Ensure that there are no excused personal notes without an absence")
+    problem_name = _("The personal note is marked as excused, but not as absent.")
+    solve_options = {
+        ResetPersonalNoteSolveOption.name: ResetPersonalNoteSolveOption,
+        IgnoreSolveOption.name: IgnoreSolveOption,
+    }
+
+    @classmethod
+    def check_data(cls):
+        from aleksis.core.models import DataCheckResult
+
+        from .models import PersonalNote
+
+        ct = ContentType.objects.get_for_model(PersonalNote)
+
+        personal_notes = PersonalNote.objects.filter(excused=True, absent=False)
+
+        for note in personal_notes:
+            logging.info(f"Check personal note {note}")
+            result = DataCheckResult.objects.get_or_create(
+                check=cls.name, content_type=ct, object_id=note.id
+            )