Skip to content
Snippets Groups Projects
Commit 1adc29e7 authored by Julian's avatar Julian
Browse files

Fix naming and permissions in mutations

parent a279d366
No related branches found
No related tags found
1 merge request!362Resolve "Add personal note management dialog in course book"
...@@ -189,6 +189,6 @@ class Mutation(graphene.ObjectType): ...@@ -189,6 +189,6 @@ class Mutation(graphene.ObjectType):
update_extra_marks = ExtraMarkBatchPatchMutation.Field() update_extra_marks = ExtraMarkBatchPatchMutation.Field()
delete_extra_marks = ExtraMarkBatchDeleteMutation.Field() delete_extra_marks = ExtraMarkBatchDeleteMutation.Field()
create_personal_note = PersonalNoteBatchCreateMutation.Field() create_personal_notes = PersonalNoteBatchCreateMutation.Field()
update_personal_note = PersonalNoteBatchPatchMutation.Field() update_personal_notes = PersonalNoteBatchPatchMutation.Field()
delete_personal_note = PersonalNoteBatchDeleteMutation.Field() delete_personal_notes = PersonalNoteBatchDeleteMutation.Field()
...@@ -33,7 +33,7 @@ class ExtraMarkBatchCreateMutation(BaseBatchCreateMutation): ...@@ -33,7 +33,7 @@ class ExtraMarkBatchCreateMutation(BaseBatchCreateMutation):
class ExtraMarkBatchDeleteMutation(BaseBatchDeleteMutation): class ExtraMarkBatchDeleteMutation(BaseBatchDeleteMutation):
class Meta: class Meta:
model = ExtraMark model = ExtraMark
permission_required = "alsijil.delete_extra_mark" # FIXME permissions = ("alsijil.delete_extra_mark",) # FIXME
class ExtraMarkBatchPatchMutation(BaseBatchPatchMutation): class ExtraMarkBatchPatchMutation(BaseBatchPatchMutation):
......
...@@ -42,7 +42,7 @@ class ParticipationStatusType( ...@@ -42,7 +42,7 @@ class ParticipationStatusType(
return NewPersonalNote.objects.filter( return NewPersonalNote.objects.filter(
person=root.person, person=root.person,
documentation=root.related_documentation, documentation=root.related_documentation,
note__isnull=False, extra_mark__isnull=True,
) )
......
...@@ -28,6 +28,8 @@ class PersonalNoteType( ...@@ -28,6 +28,8 @@ class PersonalNoteType(
class PersonalNoteBatchCreateMutation(BaseBatchCreateMutation): class PersonalNoteBatchCreateMutation(BaseBatchCreateMutation):
class Meta: class Meta:
model = NewPersonalNote model = NewPersonalNote
type_name = "BatchCreatePersonalNoteInput"
return_field_name = "personalNotes"
fields = ("note", "extra_mark", "documentation", "person") fields = ("note", "extra_mark", "documentation", "person")
permissions = ("alsijil.create_personal_note",) # FIXME permissions = ("alsijil.create_personal_note",) # FIXME
...@@ -35,10 +37,12 @@ class PersonalNoteBatchCreateMutation(BaseBatchCreateMutation): ...@@ -35,10 +37,12 @@ class PersonalNoteBatchCreateMutation(BaseBatchCreateMutation):
class PersonalNoteBatchPatchMutation(BaseBatchPatchMutation): class PersonalNoteBatchPatchMutation(BaseBatchPatchMutation):
class Meta: class Meta:
model = NewPersonalNote model = NewPersonalNote
type_name = "BatchPatchPersonalNoteInput"
return_field_name = "personalNotes"
fields = ("id", "note", "extra_mark", "documentation", "person") fields = ("id", "note", "extra_mark", "documentation", "person")
permissions = ("alsijil.change_personal_note",) # FIXME permissions = ("alsijil.change_personal_note",) # FIXME
class PersonalNoteBatchDeleteMutation(BaseBatchDeleteMutation): class PersonalNoteBatchDeleteMutation(BaseBatchDeleteMutation):
class Meta: class Meta:
model = NewPersonalNote model = NewPersonalNote
permission_required = "alsijil.delete_personal_note" # FIXME permissions = ("alsijil.delete_personal_note",) # FIXME
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment