Remove legacy caching methods

aleksis/apps/alsijil/forms.py

@@ -46,11 +46,6 @@ class PersonalNoteForm(forms.ModelForm):
         if self.instance and getattr(self.instance, "person", None):
             self.fields["person_name"].initial = str(self.instance.person)
 
-        self.fields["extra_marks"].choices = [(e.id, str(e)) for e in ExtraMark.all]
-        self.fields["excuse_type"].choices = [(None, "-----")] + [
-            (e.id, str(e)) for e in ExcuseType.all
-        ]
-
 
 class SelectForm(forms.Form):
     layout = Layout(Row("group", "teacher"))

aleksis/apps/alsijil/model_extensions.py

@@ -245,7 +245,7 @@ def get_extra_marks(
         week = self.week
 
     stats = {}
-    for extra_mark in ExtraMark.all:
+    for extra_mark in ExtraMark.objects.all():
         qs = self.personal_notes.filter(
             week=week.week, year=week.year, extra_marks=extra_mark
         )

aleksis/apps/alsijil/models.py

@@ -36,12 +36,6 @@ class ExcuseType(ExtensibleModel):
     def count_label(self):
         return f"{self.short_name}_count"
 
-    @classproperty
-    @cache_memoize(3600)
-    def all(cls):
-        qs = cls.objects.all()
-        return qs
-
     class Meta:
         ordering = ["name"]
         verbose_name = _("Excuse type")
@@ -215,11 +209,6 @@ class ExtraMark(ExtensibleModel):
     def count_label(self):
         return f"{self.short_name}_count"
 
-    @classproperty
-    @cache_memoize(3600)
-    def all(cls):
-        return cls.objects.all()
-
     class Meta:
         ordering = ["short_name"]
         verbose_name = _("Extra mark")