Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-App-Alsijil
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-App-Alsijil
Commits
eccf76aa
Verified
Commit
eccf76aa
authored
4 years ago
by
Jonathan Weth
Browse files
Options
Downloads
Patches
Plain Diff
Rename annotate_object_permission_checker to set_object_permission_checker
parent
63cf2994
No related branches found
No related tags found
1 merge request
!165
Optimize object permission queries by using django-guardian's prefetch util
Pipeline
#6559
passed
4 years ago
Stage: test
Stage: build
Stage: publish
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
aleksis/apps/alsijil/views.py
+3
-3
3 additions, 3 deletions
aleksis/apps/alsijil/views.py
with
3 additions
and
3 deletions
aleksis/apps/alsijil/views.py
+
3
−
3
View file @
eccf76aa
...
...
@@ -197,7 +197,7 @@ def register_object(
# Create a formset that holds all personal notes for all persons in this lesson
checker
=
ObjectPermissionChecker
(
request
.
user
)
checker
.
prefetch_perms
(
register_object
.
get_groups
().
all
())
register_object
.
annotate
_object_permission_checker
(
checker
)
register_object
.
set
_object_permission_checker
(
checker
)
if
not
request
.
user
.
has_perm
(
"
alsijil.view_register_object_personalnote
"
,
register_object
):
persons
=
Person
.
objects
.
filter
(
pk
=
request
.
user
.
person
.
pk
)
else
:
...
...
@@ -480,7 +480,7 @@ def week_view(
if
note
.
lesson_period
:
note
.
lesson_period
.
annotate_week
(
wanted_week
)
personal_notes
.
append
(
note
)
person
.
annotate
_object_permission_checker
(
checker
)
person
.
set
_object_permission_checker
(
checker
)
persons
.
append
({
"
person
"
:
person
,
"
personal_notes
"
:
personal_notes
})
else
:
persons
=
None
...
...
@@ -859,7 +859,7 @@ def overview_person(request: HttpRequest, id_: Optional[int] = None) -> HttpResp
)
personal_notes_list
=
[]
for
note
in
personal_notes
:
note
.
annotate
_object_permission_checker
(
checker
)
note
.
set
_object_permission_checker
(
checker
)
personal_notes_list
.
append
(
note
)
context
[
"
personal_notes
"
]
=
personal_notes_list
context
[
"
excuse_types
"
]
=
ExcuseType
.
objects
.
all
()
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment