Merge branch 'fix-dialog-object-forms-internal-dialog-mode-handling' into 'master'

Fix dialog-Object-Form's internal dialog-mode-handling

See merge request !1793

CHANGELOG.rst

@@ -27,6 +27,7 @@ Fixed
 * Recurring events without until value weren't shown.
 * It wasn't possible to change icons of OAuth applications in the frontend.
 * First fetching of calendar feeds logged an error to console.
+* [Dev] Dialog-Object-Form's internal dialog-mode-handling did not implement opening via activator slot.
 
 `4.0`_ - 2025-03-29
 -------------------

aleksis/core/frontend/components/generic/dialogs/DialogObjectForm.vue

 <template>
   <mobile-fullscreen-dialog
-    v-model="dialog"
+    v-model="dialogMode"
     max-width="555px"
     :close-button="false"
   >
@@ -26,7 +26,7 @@
         :valid.sync="valid"
         @loading="handleLoading"
         @save="handleSave"
-        @cancel="dialog = false"
+        @cancel="dialogMode = false"
       >
         <template v-for="(_, slot) of $scopedSlots" #[slot]="scope"
           ><slot :name="slot" v-bind="scope"
@@ -35,7 +35,7 @@
     </template>
 
     <template #actions>
-      <cancel-button @click="dialog = false" :disabled="loading" />
+      <cancel-button @click="dialogMode = false" :disabled="loading" />
       <save-button
         @click="$refs.form.submit()"
         :loading="loading"
@@ -67,22 +67,9 @@ export default {
   },
   mixins: [openableDialogMixin, objectFormPropsMixin, loadingMixin],
   emits: ["cancel", "save"],
-  computed: {
-    dialog: {
-      get() {
-        return this.value;
-      },
-      set(newValue) {
-        this.$emit("input", newValue);
-      },
-    },
-  },
   methods: {
-    close() {
-      this.dialog = false;
-    },
     handleSave(items) {
-      this.dialog = false;
+      this.dialogMode = false;
       this.$emit("save", items);
     },
   },

aleksis/core/frontend/mixins/objectFormMixin.js

@@ -47,7 +47,6 @@ export default {
       this.$emit("cancel");
     },
     handleSuccess() {
-      this.dialog = false;
       let snackbarTextKey = this.isCreate
         ? this.createSuccessMessageI18nKey
         : this.editSuccessMessageI18nKey;

aleksis/core/frontend/mixins/openableDialogMixin.js

 export default {
   props: {
     /**
-     * Dialog state (open or closed)
+     * Dialog-mode (open or closed)
      * @model
      * @values true,false
      */
@@ -11,4 +11,25 @@ export default {
     },
   },
   emits: ["input"],
+  data() {
+    return {
+      internalDialogMode: this.value,
+    };
+  },
+  computed: {
+    dialogMode: {
+      get() {
+        return this.internalDialogMode;
+      },
+      set(newValue) {
+        this.internalDialogMode = newValue;
+        this.$emit("input", newValue);
+      },
+    },
+  },
+  mounted() {
+    this.$watch("value", (newVal) => {
+      this.dialogMode = newVal;
+    });
+  },
 };