Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-Core
Commits
adbca0d3
Verified
Commit
adbca0d3
authored
5 months ago
by
Jonathan Weth
Browse files
Options
Downloads
Patches
Plain Diff
Deny access to PDF files for unauthenticated users
parent
acce2ce3
No related branches found
No related tags found
1 merge request
!1692
Fix security issue
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.rst
+1
-0
1 addition, 0 deletions
CHANGELOG.rst
aleksis/core/schema/__init__.py
+3
-3
3 additions, 3 deletions
aleksis/core/schema/__init__.py
with
4 additions
and
3 deletions
CHANGELOG.rst
+
1
−
0
View file @
adbca0d3
...
@@ -96,6 +96,7 @@ Fixed
...
@@ -96,6 +96,7 @@ Fixed
* Update and fix URLs for 3rdparty login.
* Update and fix URLs for 3rdparty login.
* The OpenID Connect Discovery endpoint now returns the issuer data directly
* The OpenID Connect Discovery endpoint now returns the issuer data directly
under the URI without a trailing `/`.
under the URI without a trailing `/`.
* Not-logged in users were able to access all PDF files.
Removed
Removed
~~~~~~~
~~~~~~~
...
...
This diff is collapsed.
Click to expand it.
aleksis/core/schema/__init__.py
+
3
−
3
View file @
adbca0d3
...
@@ -246,9 +246,9 @@ class Query(graphene.ObjectType):
...
@@ -246,9 +246,9 @@ class Query(graphene.ObjectType):
def
resolve_pdf_by_id
(
root
,
info
,
id
,
**
kwargs
):
# noqa
def
resolve_pdf_by_id
(
root
,
info
,
id
,
**
kwargs
):
# noqa
pdf_file
=
PDFFile
.
objects
.
get
(
pk
=
id
)
pdf_file
=
PDFFile
.
objects
.
get
(
pk
=
id
)
if
has_person
(
info
.
context
)
and
info
.
context
.
user
.
person
!
=
pdf_file
.
person
:
if
has_person
(
info
.
context
)
and
info
.
context
.
user
.
person
=
=
pdf_file
.
person
:
return
Non
e
return
pdf_fil
e
return
pdf_fil
e
return
Non
e
def
resolve_search_snippets
(
root
,
info
,
query
,
limit
=-
1
,
**
kwargs
):
def
resolve_search_snippets
(
root
,
info
,
query
,
limit
=-
1
,
**
kwargs
):
indexed_models
=
UnifiedIndex
().
get_indexed_models
()
indexed_models
=
UnifiedIndex
().
get_indexed_models
()
...
...
This diff is collapsed.
Click to expand it.
Jonathan Weth
@hansegucker
mentioned in commit
5bd04add
·
5 months ago
mentioned in commit
5bd04add
mentioned in commit 5bd04add5a55a20a908497ce25e70cc6ee87a717
Toggle commit list
Jonathan Weth
@hansegucker
mentioned in commit
919e8759
·
5 months ago
mentioned in commit
919e8759
mentioned in commit 919e875903f3f04d887476f38b972882f4bc426f
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment