Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Edward Betts
AlekSIS-Core
Commits
083adaaf
Verified
Commit
083adaaf
authored
3 years ago
by
Jonathan Weth
Browse files
Options
Downloads
Patches
Plain Diff
Remove broken notifications menu item
parent
51f09e95
No related branches found
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG.rst
+1
-0
1 addition, 0 deletions
CHANGELOG.rst
aleksis/core/menus.py
+0
-14
0 additions, 14 deletions
aleksis/core/menus.py
aleksis/core/util/core_helpers.py
+0
-5
0 additions, 5 deletions
aleksis/core/util/core_helpers.py
with
1 addition
and
19 deletions
CHANGELOG.rst
+
1
−
0
View file @
083adaaf
...
...
@@ -25,6 +25,7 @@ Fixed
* The icons in the account menu were still the old ones.
* Due to a merge error, the once removed account menu in the sidenav appeared again.
* Scheduled notifications were shown on dashboard before time.
* Remove broken notifications menu item in favor of item next to account menu.
Changed
~~~~~~~
...
...
This diff is collapsed.
Click to expand it.
aleksis/core/menus.py
+
0
−
14
View file @
083adaaf
from
django.conf
import
settings
from
django.utils.translation
import
gettext_lazy
as
_
from
.util.core_helpers
import
unread_notifications_badge
MENUS
=
{
"
NAV_MENU_CORE
"
:
[
{
...
...
@@ -37,18 +35,6 @@ MENUS = {
(
"
aleksis.core.util.predicates.permission_validator
"
,
"
core.view_dashboard_rule
"
)
],
},
{
"
name
"
:
_
(
"
Notifications
"
),
"
url
"
:
"
notifications
"
,
"
svg_icon
"
:
"
mdi:bell-outline
"
,
"
badge
"
:
unread_notifications_badge
,
"
validators
"
:
[
(
"
aleksis.core.util.predicates.permission_validator
"
,
"
core.view_notifications_rule
"
,
),
],
},
{
"
name
"
:
_
(
"
Admin
"
),
"
url
"
:
"
#
"
,
...
...
This diff is collapsed.
Click to expand it.
aleksis/core/util/core_helpers.py
+
0
−
5
View file @
083adaaf
...
...
@@ -321,11 +321,6 @@ def generate_random_code(length, packet_size) -> str:
return
get_random_string
(
packet_size
*
length
).
lower
()
def
unread_notifications_badge
(
request
:
HttpRequest
)
->
int
:
"""
Generate badge content with the number of unread notifications.
"""
return
request
.
user
.
person
.
unread_notifications_count
def
monkey_patch
()
->
None
:
# noqa
"""
Monkey-patch dependencies for special behaviour.
"""
# Unwrap promises in JSON serializer instead of stringifying
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment