* test-getdate.sh (valid_timezone): Fix incorrect return values.

(expand_modules): Removed this stub function.
(get_history_log_name): Don't return const since it is freshly
allocated.
(history_write): Add version number to history records.  Use tag
fields like other record types.
(fill_hrec): Load version number & postprocess history records as
needed.  Zero records with memset.
(read_hrecs_file): Don't zero records redundantly with fill_hrec().
(report_hrecs): Find tag data in the same place as other record types.
* sanity.sh (basic2-64): Expect new tag records.
* tag.c: Some cleanup.
(cvstag): Move history log call to...
(tag_filesdoneproc): ...here, where we have more information.

* subr.h [NULL2DOT, NULL2MT]: Add parens for safety.

only one function which restored its state on exit, and it even
uselessly duplicated the value of another variable within that
function.

assertion.

cleanup.
* recurse.c (repository, struct recursion_frame, start_recursion):
Declare repository const char *.
(do_recursion, do_dir_proc): Ditto.  Some cleanup.
* recurse.h (start_recursion): Update prototype to match.
* subr.h (REPLACE): New convenience macro.
* update.c (do_update): Cleanup traces.

* parseinfo.c (Parse_Info): Add function trace.

and composing update_dir.  Incidentally fixes a few other minor bugs.
* commit.c (commit_direntproc): Handle corrected update_dir.
* recurse.c (do_dir_proc): Preserve update_dir.  Clean up.
* sanity.sh: Compensate for correctly preserved update_dir.

* hash.h (printlist): Add prototype.
* ls.c (ls_direntproc): Add function trace.
* recurse.c (do_recursion): Condense traces.
(do_file_proc, do_dir_proc): Add function traces.

commit.

(do_file_proc): Cleanup.  Try harder to preserve update_dir.
* server.c: Cleanup.
(output_dir): Become wrapper for...
(output_dir_i): ...this new function used...
(serve_notify): ...here to avoid code duplication.
* sanity.sh (server): Compensate for correct notify repository line.

* repos.c (Short_Repository): Improve header comment.  Assert truths.
Strip all trailing slashes.

(checkout_proc): Pass empty update_dir to build_one_dir.
* create_adm.c: Some cleanup.
* rcs.c (RCS_setattic): Simplify via cvs_mkdir().
* repos.c (Sanitize_Repository_Name): Strip any number of /.?
* subr.c (mkdir_i): Assume UPDATE_DIR is a full path when set.

* subr.c (dir_append_dirs): Extend to ignore ./*.  Improve header block
comment.
* tag.c: Some cleanup.
(check_fileproc): Improve error message.
* sanity.sh (basica-4a): Update to compensate for new error message.

* rcs.c: Likewise.
(locate_rcs): Export.  Change int arg to bool.
* rcs.h (locate_rcs): Add prototype.

functions.
* stack.h (unshift_string_array, init_string_list): Prototypes for
same.

(ncheck_filesdoneproc): ...this and call the new function...
(send_notifications): ...here for efficiency.  Some cleanup.

* find-names.h (find_dirs): Add prototype.

set by caller.
* find-names.h (Find_Names): Update prototype.
* recurse.c (do_recursion): Always open entries when available.
* sanity.sh (errmsg2-16): Update to compensate.

do_editor().
* logmsg.c (do_editor): Some cleanup.
* sanity.sh (editor): Update to compensate.

* client.c (call_in_directory): Handle preservation of update_dir from
server.  Clean up and simplify slightly.
(is_cvsroot_level): Handle empty update_dir.
* server.c (output_dir): Preserve update_dir when sending it to
client.  Clean up.
* subr.c (dir_append_dirs): Fix TRACE.

(lock_obtained, lock_wait): Only print message when !really_quiet.
(set_lock): Don't print error messages, but return errno and...
(Reader_Lock, set_promotable_lock, lock_dir_for_write, internal_lock):
...rely on callers to report the error.
(set_readlock_name, readers_exist): Declare inline.
(multiroot3-10): Update to compensate for new error messages.

they were passed.