Fix to early call of get_site_preferences

aleksis/apps/ldap/apps.py

@@ -26,5 +26,4 @@ class LDAPConfig(AppConfig):
         update_dynamic_preferences()
 
         user = get_user_model()
-        if get_site_preferences()["ldap__person_sync_on_login"]:
-            post_save.connect(ldap_sync_user_on_login, sender=user)
+        post_save.connect(ldap_sync_user_on_login, sender=user)

aleksis/apps/ldap/util/ldap_sync.py

@@ -123,6 +123,10 @@ def apply_templates(value, patterns, templates, separator="|"):
 @transaction.atomic
 def ldap_sync_user_on_login(sender, instance, created, **kwargs):
     """Synchronise Person meta-data and groups from ldap_user on User update."""
+    # Check if sync on login is activated
+    if not get_site_preferences()["ldap__person_sync_on_login"]:
+        return
+
     # Semaphore to guard recursive saves within this signal
     if getattr(instance, "_skip_signal", False):
         return